Skip to content

Define the "suse" class on SLED systems#5773

Merged
olehermanse merged 1 commit into
cfengine:masterfrom
amousset:sled-suse-alias
May 28, 2025
Merged

Define the "suse" class on SLED systems#5773
olehermanse merged 1 commit into
cfengine:masterfrom
amousset:sled-suse-alias

Conversation

@amousset

@amousset amousset commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

When running the agent on a SLED (SUSE Linux Enterprise Desktop), we get:

CFEngine(common)  Operating System not properly recognized, setting sys.os_name_human to "Unknown", please submit a bug report for us to fix this

This is caused by the OS detection skipping the suse alias on SLED systems.

@amousset amousset force-pushed the sled-suse-alias branch 3 times, most recently from 1fb322a to f859b1c Compare April 18, 2025 09:52
@amousset amousset changed the title Define suse class on SLED systems Define the "suse" class on SLED systems Apr 18, 2025
@cf-bottom

Copy link
Copy Markdown

Thanks for submitting a PR! Maybe @larsewi can review this?

@craigcomstock craigcomstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

@craigcomstock craigcomstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in the middle of releasing new version so are in a code freeze.

Will merge after release.

@github-actions

Copy link
Copy Markdown

Marking this PR as stale due to inactivity; it will be closed in 7 days.

@github-actions github-actions Bot added the stale Pull requests with no recent activity label May 26, 2025
@ElaadF

ElaadF commented May 27, 2025

Copy link
Copy Markdown

We are in the middle of releasing new version so are in a code freeze.

Will merge after release.

Hi @craigcomstock, do you think this can me merge, or you are still in a code freeze situation?

@larsewi

larsewi commented May 27, 2025

Copy link
Copy Markdown
Contributor

@cf-bottom Jenkins please :)

@larsewi larsewi removed after-release stale Pull requests with no recent activity labels May 27, 2025
@cf-bottom

Copy link
Copy Markdown

@craigcomstock

Copy link
Copy Markdown
Contributor

We are in the middle of releasing new version so are in a code freeze.
Will merge after release.

Hi @craigcomstock, do you think this can me merge, or you are still in a code freeze situation?

Yes, @larsewi requested a build and we will work through it to get it merged.

@craigcomstock

Copy link
Copy Markdown
Contributor

Failures here are flakes in our CI, backend channel disconnected. Retry.

@cf-bottom jenkins build please

@craigcomstock craigcomstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting to see if CI can be green enough.

@cf-bottom

Copy link
Copy Markdown

@olehermanse olehermanse added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 28, 2025
@olehermanse olehermanse merged commit 16b1e6d into cfengine:master May 28, 2025
@larsewi

larsewi commented May 30, 2025

Copy link
Copy Markdown
Contributor

@larsewi larsewi removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants