fix(android): fix crashes and faulty preview on Chrome 86+#125
Open
timbru31 wants to merge 1 commit intocesarvr:masterfrom
Open
fix(android): fix crashes and faulty preview on Chrome 86+#125timbru31 wants to merge 1 commit intocesarvr:masterfrom
timbru31 wants to merge 1 commit intocesarvr:masterfrom
Conversation
timbru31
commented
Sep 15, 2020
| super.onWriteFailed(error); | ||
|
|
||
| Log.d(TAG, "onWriteFailed: Failed!!! " + error.toString() ); | ||
| LOG.e(LOG_TAG, "onWriteFailed: Failed: " + error); |
Contributor
Author
There was a problem hiding this comment.
Here lies the reason of the crash. The error might be null according to the JavaDocs: https://developer.android.com/reference/android/print/PrintDocumentAdapter.WriteResultCallback#onWriteFailed(java.lang.CharSequence)
timbru31
commented
Sep 15, 2020
| LOG.i(APPNAME, "Cleaning pdfwriter & webView objects."); | ||
| LOG.d(LOG_TAG, "Cleaning pdfwriter & webView objects."); | ||
| mWrappedInstance.onFinish(); | ||
| webView.destroy(); |
Contributor
Author
There was a problem hiding this comment.
This ensures to destroy the webView instance after the user either printed or cancelled the share PDF intent.
timbru31
force-pushed
the
fix/android-crashes-chrome-86+
branch
from
acc5f50 to
3b78a66
Compare
timbru31
commented
Sep 15, 2020
| LOG.e(LOG_TAG, "getAsBase64 Error in I/O: ", ex); | ||
| cordovaCallback.error(IO_EXCEPTION); | ||
| } finally { | ||
| this.webView.destroy(); |
Contributor
Author
There was a problem hiding this comment.
This ensures that in both the success and error case of the base64 request the webView is successfully destroyed again.
timbru31
force-pushed
the
fix/android-crashes-chrome-86+
branch
from
3b78a66 to
d927e2d
Compare
timbru31
commented
Sep 15, 2020
| //.setMinMargins(PrintAttributes.Margins.NO_MARGINS).build(); | ||
|
|
||
|
|
||
| PrintDocumentAdapter printAdapter = null; |
Contributor
Author
There was a problem hiding this comment.
Before, a printerAdapater was always initialized, even when the target was share which uses the printerManager. Therefore, this code block was moved to the if block.
This is achieved by always using a new WebView instance and by destorying the old one fix(android): correct file name for temp folder fix(android): remove unused config file fix(android): register only one printer adapter fix(android): do not crash if error code is null (which is valid) refactor(android): use Cordova's log helper style: reformat codebase
timbru31
force-pushed
the
fix/android-crashes-chrome-86+
branch
from
d927e2d to
04c7491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is achieved by always using a new WebView instance and by destorying the old one
fix(android): correct file name for temp folder
fix(android): remove unused config file
fix(android): register only one printer adapter
fix(android): do not crash if error code is null (which is valid)
refactor(android): use Cordova's log helper
style: reformat codebase
This fixes #124