Skip to content

feat: use VS Code hover widget colors for tooltip backgrounds #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcottercertinia merged 1 commit into from
Apr 2, 2026
Merged

feat: use VS Code hover widget colors for tooltip backgrounds #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions log-viewer/src/features/timeline/components/TimelineView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,20 @@ export class TimelineView extends LitElement {
--tl-widget-border: var(--vscode-editorWidget-border, #454545);
--tl-widget-foreground: var(--vscode-editorWidget-foreground, #cccccc);

/* Hover/tooltip */
--tl-hover-background: var(
--vscode-editorHoverWidget-background,
var(--vscode-editorWidget-background, #252526)
);
--tl-hover-border: var(
--vscode-editorHoverWidget-border,
var(--vscode-editorWidget-border, #454545)
);
--tl-hover-foreground: var(
--vscode-editorHoverWidget-foreground,
var(--vscode-editorWidget-foreground, #cccccc)
);

/* Text */
--tl-description-foreground: var(--vscode-descriptionForeground, #999);
--tl-font-family: var(--vscode-font-family, sans-serif);
Expand Down
6 changes: 3 additions & 3 deletions log-viewer/src/features/timeline/optimised/rendering/tooltip-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ export const PERCENT_THRESHOLD_BREACH = 1.0;
*/
export const TOOLTIP_CSS = {
/** Background color */
background: 'var(--tl-widget-background, #252526)',
background: 'var(--tl-hover-background, #252526)',
/** Border color */
border: 'var(--tl-widget-border, #454545)',
border: 'var(--tl-hover-border, #454545)',
/** Text color */
foreground: 'var(--tl-widget-foreground, #e3e3e3)',
foreground: 'var(--tl-hover-foreground, #e3e3e3)',
/** Description/secondary text color */
descriptionForeground: 'var(--tl-description-foreground, #999)',
/** Muted description text color */
Expand Down
8 changes: 4 additions & 4 deletions log-viewer/src/features/timeline/styles/timeline.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export const tooltipStyles = `
padding: 5px;
border-radius: 4px;
border-left: 4px solid;
background-color: var(--tl-editor-background);
color: var(--tl-editor-foreground);
background-color: var(--tl-hover-background);
color: var(--tl-hover-foreground);
font-family: monospace;
font-size: 0.92rem;
pointer-events: auto;
Expand Down Expand Up @@ -47,16 +47,16 @@ export const tooltipStyles = `
white-space: nowrap;
text-overflow: ellipsis;
padding-right: 12px;
color: var(--tl-description-foreground, #999);
opacity: 0.9;
}

.tooltip-value {
flex-shrink: 0;
font-variant-numeric: tabular-nums;
font-weight: 500;
font-family: monospace;
opacity: 0.9;
text-align: right;
white-space: pre-wrap;
color: var(--tl-description-foreground, #999)
}
`;
26 changes: 14 additions & 12 deletions log-viewer/src/tabulator/style/DataGrid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ $footerTextColor: var(--vscode-editor-foreground); //footer text color
$footerBorderColor: transparent; //footer border color
$footerSeparatorColor: transparent; //footer bottom separator color
$footerActiveColor: #d00 !default; //footer bottom active text color

@import '~tabulator-tables/src/scss/tabulator.scss';
@import '../editors/MinMax';
@import '../format/Progress';
Expand Down Expand Up @@ -102,18 +103,6 @@ $footerActiveColor: #d00 !default; //footer bottom active text color
font-size: var(--vscode-editor-font-size, 0.9em);
}

.tabulator-tooltip {
// Match timeline tooltip styling for consistency
background: var(--vscode-editor-background);
color: var(--vscode-editor-foreground);
overflow-wrap: anywhere;
font-family: monospace;
font-size: 0.92rem;
font-variant-numeric: tabular-nums;
padding: 5px;
border-radius: 4px;
box-shadow: 0 8px 24px rgba(0, 0, 0, 0.5);
}
.tabulator-row.tabulator-selected {
color: var(--vscode-list-activeSelectionForeground);
}
Expand Down Expand Up @@ -155,6 +144,19 @@ $footerActiveColor: #d00 !default; //footer bottom active text color
}
}

.tabulator-tooltip {
// Match timeline tooltip styling for consistency
background: var(--vscode-editorHoverWidget-background, var(--vscode-editorWidget-background));
color: var(--vscode-editorHoverWidget-foreground, var(--vscode-editor-foreground));
overflow-wrap: anywhere;
font-family: monospace;
font-size: 0.92rem;
font-variant-numeric: tabular-nums;
padding: 5px;
border-radius: 4px;
box-shadow: 0 8px 24px rgba(0, 0, 0, 0.5);
}

.tabulator-edit-list {
border-color: var(--vscode-focusBorder, default);

Expand Down
Loading