Open
Conversation
Owner
|
I think we need to add appropriate tests for these. My first question: Were you able to run the tests and see any of them failed? If yes, do they pass now? If no, you should have created failing test first. |
Author
|
Seeing as there's no additional functionality, and the script fails on macOS (without these changes), the existing tests:
I can add more if you like, what were you wanting to test? FWIW, I also fixed an issue that caused tests (on Running tests on Linux ( Running tests on macOS ( Running tests on macOS (this PR - #2 ) Running tests on linux (this PR - #2) |
Owner
|
Nice! |
Owner
|
FYI: I'll test and merge ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




MacOS / BSD:
realpathcommand (created alternative functionmy_realpath)-printfflag onfind(replaced with GNU shell parameter expansion, compatible with BSD and ZSH)readarraycommand (created array in a loop instead)ZSH:
Tested on macOS/ZSH and Linux/Bash