fix: cephadm_bootstrap should check /etc/ceph for idempotency#41
Open
dotoleeoak wants to merge 2 commits into
Open
fix: cephadm_bootstrap should check /etc/ceph for idempotency#41dotoleeoak wants to merge 2 commits into
dotoleeoak wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes cephadm_bootstrap idempotency detection by checking for existing Ceph config artifacts under the default config directory (/etc/ceph) instead of /var/lib/ceph, aligning the module behavior with Ceph’s default configuration location.
Changes:
- Update idempotency path checks in
cephadm_bootstrapto use/etc/ceph. - Add unit tests covering idempotent skip behavior and
allow_overwritebehavior. - Add a changelog fragment describing the bugfix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugins/modules/cephadm_bootstrap.py |
Switch idempotency “already deployed” checks from /var/lib/ceph to /etc/ceph. |
tests/unit/modules/test_cephadm_bootstrap.py |
Add unit tests validating the updated idempotency behavior and overwrite override. |
changelogs/fragments/cephadm_bootstrap_idempotency.yaml |
Document the idempotency path correction (contains a small typo). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module cephadm_bootstrap should check if Ceph config already exists for idempotency check.
The module has been checking '/var/lib/ceph', while the default config dir is '/etc/ceph'.
The bug introduced from upstream: ceph/cephadm-ansible@2645b6a