ceph_config: add support for removing config options#29
Open
dagaaryan011 wants to merge 1 commit into
Open
Conversation
asm0deuz
reviewed
Mar 27, 2026
| - whether to get, set, or remove the parameter specified in 'option' | ||
| type: str | ||
| choices: ['get', 'set'] | ||
| choices: ['get', 'set','remove'] |
Collaborator
There was a problem hiding this comment.
Suggested change
| choices: ['get', 'set','remove'] | |
| choices: ['get', 'set', 'remove'] |
Missing space
asm0deuz
reviewed
Mar 27, 2026
| argument_spec=dict( | ||
| who=dict(type='str', required=True), | ||
| action=dict(type='str', required=False, choices=['get', 'set'], default='set'), | ||
| action=dict(type='str', required=False, choices=['get', 'set','remove'], default='set'), |
Collaborator
There was a problem hiding this comment.
Suggested change
| action=dict(type='str', required=False, choices=['get', 'set','remove'], default='set'), | |
| action=dict(type='str', required=False, choices=['get', 'set', 'remove'], default='set'), |
Missing space, PEP8 will complain
asm0deuz
reviewed
Mar 27, 2026
| rc, out, err = module.run_command(cmd) | ||
|
|
||
| return rc, cmd, out.strip(), err | ||
| def remove_option(module: "AnsibleModule", |
Collaborator
There was a problem hiding this comment.
Missing space above that line
asm0deuz
reviewed
Mar 27, 2026
| else: | ||
| rc, cmd, out, err = set_option(module, who, option, value) | ||
| changed = True | ||
| if module.check_mode: |
Collaborator
There was a problem hiding this comment.
Ansible expects the out variable (and other outputs) to be identical between check mode and real execution. Your outputs are different between a dry-run and a real execution which is expected.
It breaks Ansible's idempotency model and causes unexpected behavior in playbooks that check task outputs or use conditional logic based on module results.
asm0deuz
requested changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for removing Ceph configuration overrides via the
ceph_config Ansible module by introducing a new
action: remove, whichinvokes
ceph config rmunder the hood.This allows users to explicitly delete existing configuration overrides
instead of overwriting them, enabling clean rollbacks to inherited or
default configuration values. The removal operation is implemented in an
idempotent manner: if no override exists for the given daemon and option,
the task is a no-op.
The implementation is consistent with existing command construction logic
(using build_base_cmd_shell) and fully respects Ansible check mode semantics,
ensuring that configuration removals can be safely previewed without
mutating cluster state.
Fixes #28.