Draft
Conversation
Contributor
Author
|
Waiting for review request until Recon run has finished and was triaged |
|
Coverage after merging invariants_base-transfer-hook into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product requirements
is*classifier returns true for any (from, to) pair (based on https://kflabs.slack.com/archives/C07PG2EUR9C/p1759218172532609?thread_ts=1759173152.483119&cid=C07PG2EUR9C )property_cancelled_soundnesswithvaultIsSetmodifier to prevent early reverts before deploymentDesign notes
HookTargets.solcontract added to the Recon target hierarchy, exercisingFullRestrictionstransfer classifiers against arbitrary address pairshub_setSharePrice(uint128)is now the single unclamped handler;hub_setPriceZero,hub_setPriceNonZero_clamped, andhub_setPriceRealistic_clampeddelegate to it with modulo clamping instead of if-guardshub_approveRedeems_clampedandhub_issueShares_clampednow read on-chain epoch and pending state to clamp inputs to valid ranges before delegating to unclamped handlershub_notifyDeposit_clampedandhub_notifyRedeem_clampedsimplified to only clampmaxClaimsand delegate, removing dead validation code that never executed the actual notify callhub_updateJournal_clampedrefactored to delegate tohub_updateJournalinstead of duplicating inline logic