Skip to content

Idea: BatchSimplePriceManager#656

Draft
onnovisser wants to merge 101 commits intomainfrom
batchsimplepricemanager
Draft

Idea: BatchSimplePriceManager#656
onnovisser wants to merge 101 commits intomainfrom
batchsimplepricemanager

Conversation

@onnovisser
Copy link
Copy Markdown
Contributor

@onnovisser onnovisser commented Oct 1, 2025

Product requirements

  • Methods for approving and issuing on top of the SimplePriceManager

Design notes

  • How do we solve the deRWA use-case? Splitting approve and issue/revoke can lead to the price being wrong, even when tracking how many issue/revoke epochs behind we are

TODOs

  • [ ]

@onnovisser onnovisser added the 💡 idea Represent an idea draft based on a conversation label Oct 1, 2025
@sherlock-ai-github-agent
Copy link
Copy Markdown

Sherlock AI Findings

The automated tool identified the following potential security issues in the codebase. Please review the details for each issue in the linked dashboard.

# Title Severity Details
1 Incorrect NAV Per Share Calculation When Issuance is Zero During Share Revocation Medium View Details

Next Steps: Review the linked issues in the dashboard and address high-severity bugs first. Contact the team if you need assistance.

Full report available at: https://ai.sherlock.xyz/runs/a7dbdf25-f002-43e4-935a-6242ff419ff6

Base automatically changed from nav-manager to main October 2, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💡 idea Represent an idea draft based on a conversation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants