fix(map): set imageBorder on resource cells for visible outlines#239
Open
fix(map): set imageBorder on resource cells for visible outlines#239
Conversation
Commit ed4ec78 removed the setCellStyles(IMAGE_BORDER) calls that were setting imageBorder on cells at insertion time. This was done because the hardcoded color values did not adapt to theme changes. However, mxImageShape only draws its border when imageBorder is set, so removing it made resource outlines invisible in the editor. Set imageBorder to "default" instead of a hardcoded color. This lets drawio's replaceDefaultColors resolve it to the correct theme color at render time, while the centreon-map frontend translates between "default" (drawio) and "#" (backend sentinel) on load/save. Refs: MON-196738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: MON-196738
Commit ed4ec78 removed the
setCellStyles(IMAGE_BORDER)calls that weresetting
imageBorderon cells at insertion time. This was done because thehardcoded color values (
#000000/#ffffff) did not adapt to theme changes.However,
mxImageShapeonly draws its border rect whenimageBorderisnon-null, so removing it made resource outlines invisible in the editor.
This PR sets
imageBorderto"default"instead of a hardcoded color. Thislets drawio's
replaceDefaultColorsresolve it to the correct theme-awareforeground color at render time. The centreon-map frontend translates between
"default"(drawio) and"#"(backend sentinel) on load/save.Companion PR in centreon-modules: https://github.com/centreon/centreon-modules/pull/7796
Type of change