Add SFP port mode to brocade plugin

[rmorandell-pgum]

Community contributors

Description

The plugin has been extended to include a --list-sfp-ports mode and a --sfp-port option.

In addition, the standard SNMP modes --tcp-con, --udp-con, and --uptime have been added.

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

The walk is from a ExtremeSLX9640 switch but is based on the brocade MIBs .1.3.6.1.4.1.1588

BROCADE-OPTICAL-MONITORING-MIB.mib.txt.

extremeSLX.-brocadesnmpwalk.txt.zip

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• I have provide data or shown output displaying the result of this code in the plugin area concerned.

---

Centreon team (internal PR)

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID

Please include a short resume of the changes and what is the purpose of this pull request.
Any relevant information should be added to help reviewers to understand what are the stakes
of the pull request.

Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.
If you are fixing one or more JIRA ticket, mention it here too.

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• In case of a new plugin, I have created the new packaging directory accordingly.
• I have implemented automated tests related to my commits.
  • Data used for automated tests are anonymized.
• I have reviewed all the help messages in all the .pm files I have modified.
  • All sentences begin with a capital letter.
  • All sentences end with a period.
  • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
• After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

Summary by Aikido

Security Issues: 0	🔍 Quality Issues: 1	Resolved Issues: 0

🚀 New Features

• Added SFP port monitoring mode and SFP ports listing mode.

⚡ Enhancements

• Added standard SNMP modes tcp-con, udp-con, and uptime.
• Extended list-sfp-ports to include TX and RX power status.
• Introduced statefile-based caching to reduce SNMP requests.

🔧 Refactors

• Improved performance for interface name loading during discovery.
• Refactored help and output formatting across new SFP modes.

^{More info}

[aikido-pr-checks]

User-controlled display_transform_src/dst are interpolated into a string passed to Safe->reval, enabling code/regex injection. Avoid constructing/evaluating code from untrusted options.

Details

✨ AI Reasoning
​The code builds a Perl substitution expression using user-provided options display_transform_src and display_transform_dst, then executes it via Safe->reval. This composes executable code strings from external input, which can lead to code injection or unexpected execution. Safe limits some operations but does not eliminate risks of crafted regular expressions or evaluation payloads that can alter program behavior. The problematic change is the addition of dynamic evaluation in get_display_value, which introduces a new execution path for untrusted input. This finding is directly tied to the changed lines where reval is invoked.

🔧 How do I fix it?
Use parameterized queries with placeholders, array-based command execution (no shell interpretation), or properly escaped arguments using vetted libraries. Avoid dynamic queries/commands built with user input concatenation.

_{Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info}