Skip to content

Mon 195013 enhance sc cache reliability#3201

Merged
jean-christophe81 merged 39 commits intodevelopfrom
MON-195013-enhance-sc-cache-reliability
Apr 10, 2026
Merged

Mon 195013 enhance sc cache reliability#3201
jean-christophe81 merged 39 commits intodevelopfrom
MON-195013-enhance-sc-cache-reliability

Conversation

@jean-christophe81
Copy link
Copy Markdown
Contributor

@jean-christophe81 jean-christophe81 commented Feb 25, 2026

REFS:MON-195013

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 23.10.x
  • 24.04.x
  • 24.10.x
  • 25.10.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 11 Resolved Issues: 0

⚡ Enhancements

  • Loaded and used global cache on endpoint creation and requests
  • Added Boost.Interprocess allocators and containers to precompiled headers

🔧 Refactors

  • Reworked InfluxDB connector/stream API to use http_tsdb::column types
  • Replaced Graphite query generation with http_tsdb line protocol methods
  • Cleaned headers/namespaces and improved logging and error handling

More info

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 25, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e445786b-5be6-404d-908a-c63c203ab172

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MON-195013-enhance-sc-cache-reliability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 25, 2026

Logo
Checkmarx One – Scan Summary & Details49f46b1d-1160-48d9-b4f3-a7767ce51920


New Issues (3) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Insufficiently_Protected_Credentials /graphite/src/factory.cc: 130
detailsMethod at line 130 of /graphite/src/factory.cc gets a user password from the db_password element. This element’s value then flows through the c...
Attack Vector
2 MEDIUM Insufficiently_Protected_Credentials /influxdb/src/influxdb.cc: 49
detailsMethod at line 49 of /influxdb/src/influxdb.cc gets a user password from the passwd element. This element’s value then flows through the code wi...
Attack Vector
3 MEDIUM Insufficiently_Protected_Credentials /influxdb/src/influxdb.cc: 250
detailsMethod at line 250 of /influxdb/src/influxdb.cc gets a user password from the passwd element. This element’s value then flows through the code w...
Attack Vector

Fixed Issues (3) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM Insufficiently_Protected_Credentials /graphite/src/factory.cc: 130
MEDIUM Insufficiently_Protected_Credentials /influxdb/src/influxdb.cc: 252
MEDIUM Insufficiently_Protected_Credentials /influxdb/src/influxdb.cc: 54

@jean-christophe81 jean-christophe81 force-pushed the MON-195013-enhance-sc-cache-reliability branch from a9b8d7f to 99074f8 Compare February 25, 2026 16:19
@jean-christophe81 jean-christophe81 force-pushed the MON-195013-enhance-sc-cache-reliability branch from 99074f8 to b981afa Compare February 25, 2026 16:20
@jean-christophe81 jean-christophe81 force-pushed the MON-195013-enhance-sc-cache-reliability branch from b981afa to 0e040bc Compare February 26, 2026 08:40
@jean-christophe81 jean-christophe81 force-pushed the MON-195013-enhance-sc-cache-reliability branch from 0e040bc to f81805e Compare February 26, 2026 08:50
@jean-christophe81 jean-christophe81 force-pushed the MON-195013-enhance-sc-cache-reliability branch from f81805e to 1a0eeb7 Compare February 26, 2026 09:00
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2026

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
5 1 0 6 83.33 11m22.68641s

Failed Tests

Name Message ⏱️ Duration Suite
LUA_FAILURE delays beetwen lua retry records are not as expected 55.436 s Lua

Comment thread broker/core/cache/create_class_from_proto.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants