Skip to content

feat: add symbolic key mappings to KeyboardUtils#42

Merged
bigboateng merged 2 commits intomainfrom
fix/add-missing-keyboard-keys
Jan 7, 2026
Merged

feat: add symbolic key mappings to KeyboardUtils#42
bigboateng merged 2 commits intomainfrom
fix/add-missing-keyboard-keys

Conversation

@bigboateng
Copy link
Contributor

@bigboateng bigboateng commented Jan 7, 2026

Important

Add symbolic key mappings to KeyboardUtils to prevent "Unknown key" errors for keys like minus, plus, slash.

  • Behavior:
    • Adds symbolic key mappings (e.g., minus, plus, slash) to keyMap in KeyboardUtils to prevent "Unknown key" errors.
  • Documentation:
    • Updates .changeset/add-missing-keyboard-keys.md to document the addition of symbolic key mappings.

This description was created by Ellipsis for 8b06340. You can customize this summary. It will automatically update as commits are pushed.

Add mappings for common symbolic keys that LLMs may try to use:
- minus, plus, equal/equals
- period/dot, comma
- slash, backslash
- bracketleft, bracketright
- semicolon, quote, backquote, tilde

Fixes 'Unknown key: minus' error in Playwright keyboard actions.
@ellipsis-dev ellipsis-dev bot changed the title ... feat: add symbolic key mappings to KeyboardUtils Jan 7, 2026
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to fb17675 in 33 seconds. Click for details.
  • Reviewed 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. tools/utils/keyboard.ts:40
  • Draft comment:
    Consider consolidating or documenting duplicate key aliases (e.g., 'equal' vs. 'equals', 'period' vs. 'dot') to avoid confusion.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. tools/utils/keyboard.ts:40
  • Draft comment:
    Ensure test coverage is updated to verify behavior for these new symbolic key mappings.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_1CgFfi4Qc1y99u8L

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@bigboateng bigboateng merged commit 9236809 into main Jan 7, 2026
1 check passed
@bigboateng bigboateng deleted the fix/add-missing-keyboard-keys branch January 7, 2026 15:02
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 8b06340 in 2 minutes and 37 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/add-missing-keyboard-keys.md:5
  • Draft comment:
    Consider adding more explicit details about the symbolic keys added (e.g., listing the specific keys) to improve clarity and linking with corresponding changes in KeyboardUtils.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_UPUjzZlhSzErs2QH

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments