feat: add symbolic key mappings to KeyboardUtils#42
Merged
bigboateng merged 2 commits intomainfrom Jan 7, 2026
Merged
Conversation
Add mappings for common symbolic keys that LLMs may try to use: - minus, plus, equal/equals - period/dot, comma - slash, backslash - bracketleft, bracketright - semicolon, quote, backquote, tilde Fixes 'Unknown key: minus' error in Playwright keyboard actions.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to fb17675 in 33 seconds. Click for details.
- Reviewed
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. tools/utils/keyboard.ts:40
- Draft comment:
Consider consolidating or documenting duplicate key aliases (e.g., 'equal' vs. 'equals', 'period' vs. 'dot') to avoid confusion. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. tools/utils/keyboard.ts:40
- Draft comment:
Ensure test coverage is updated to verify behavior for these new symbolic key mappings. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_1CgFfi4Qc1y99u8L
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 8b06340 in 2 minutes and 37 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/add-missing-keyboard-keys.md:5
- Draft comment:
Consider adding more explicit details about the symbolic keys added (e.g., listing the specific keys) to improve clarity and linking with corresponding changes in KeyboardUtils. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_UPUjzZlhSzErs2QH
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add symbolic key mappings to
KeyboardUtilsto prevent "Unknown key" errors for keys likeminus,plus,slash.minus,plus,slash) tokeyMapinKeyboardUtilsto prevent "Unknown key" errors..changeset/add-missing-keyboard-keys.mdto document the addition of symbolic key mappings.This description was created by
for 8b06340. You can customize this summary. It will automatically update as commits are pushed.