Skip to content
This repository was archived by the owner on Jan 30, 2019. It is now read-only.

Conversation

@aaronblenkush
Copy link

@aaronblenkush aaronblenkush commented Aug 11, 2017

This will allow repeated params in the query string as requested in issue #13.

query->map

(= (query->map "fq=1&fq=2&a=4&fq=3")
    {"fq" ["1" "2" "3"], "a" "4"})

map->query

(= (map->query {"fq" ["1" "2" "3"], "a" "4"})
    "a=4&fq=1&fq=2&fq=3")

@LukasRychtecky
Copy link

Could it be merged?

@saintx
Copy link

saintx commented Oct 31, 2018

Let's get this merged! Looks great to me.

Copy link

@saintx saintx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only critique is the lack of tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants