Skip to content

Remove all unnecessary headers as guided by Qt Creator on macOS. #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickerso merged 8 commits into from
Nov 27, 2025
Merged

Remove all unnecessary headers as guided by Qt Creator on macOS. #1346

nickerso merged 8 commits into from
Nov 27, 2025

Conversation

@hsorby
Copy link
Contributor

@hsorby hsorby commented Nov 25, 2025

@hsorby hsorby marked this pull request as ready for review November 27, 2025 00:42
@hsorby
Copy link
Contributor Author

hsorby commented Nov 27, 2025

It turns out that there is a lot of agreement across the tested platforms. Only Windows requiring an extra iterator include being the differenct.

@hsorby hsorby requested review from agarny and nickerso November 27, 2025 00:49
@nickerso
Copy link
Contributor

nickerso commented Nov 27, 2025

whats our confidence level that this works fine on a windows machine with Visual Studio?

nickerso
nickerso reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@nickerso nickerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems all good, will approve once I can try this with Visual Studio on my machine or if someone can give assurance that visual studio on a windows machine has been checked :)

@hsorby
Copy link
Contributor Author

hsorby commented Nov 27, 2025

100%, I have tested just this scenario using Visual Studio 2022 on Windows 10 building the Release version of the library.

@nickerso
Copy link
Contributor

nickerso commented Nov 27, 2025

100%, I have tested just this scenario using Visual Studio 2022 on Windows 10 building the Release version of the library.

Windows 10?! What about windows 11?

agarny
agarny previously approved these changes Nov 27, 2025
View reviewed changes
@hsorby hsorby requested review from agarny and nickerso November 27, 2025 01:57
@hsorby
Copy link
Contributor Author

hsorby commented Nov 27, 2025

100%, I have tested just this scenario using Visual Studio 2022 on Windows 10 building the Release version of the library.

Windows 10?! What about windows 11?

I have tested this code change with Windows 11 using Visual Studio 2022 (updated to the latest version) and it built perfectly.

@hsorby hsorby changed the title Remove all unnecessary headers according to Qt Creator on macOS. Remove all unnecessary headers as guided by Qt Creator on macOS. Nov 27, 2025
@nickerso nickerso merged commit 7cc5bea into cellml:main Nov 27, 2025
14 checks passed
@hsorby hsorby deleted the issue1344 branch November 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agarny agarny agarny approved these changes

@nickerso nickerso nickerso approved these changes

Assignees

No one assigned

Labels

Miscellaneous

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsorby @nickerso @agarny