Shrex client server specification#4665
Conversation
vgonkivs
requested review from
Wondertan,
gupadhyaya,
renaynay and
walldiss
as code owners
vgonkivs
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## shrex_spec #4665 +/- ##
=============================================
Coverage ? 35.97%
=============================================
Files ? 304
Lines ? 20170
Branches ? 0
=============================================
Hits ? 7256
Misses ? 11961
Partials ? 953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - Retrieving data from local storage | ||
| - Sending responses back to clients | ||
|
|
||
| ### Request Handling |
There was a problem hiding this comment.
in certain cases (ND), not found comes with data too (non incl proof)
There was a problem hiding this comment.
Actually false. Server sends "OK" along with non-inclusion proof
specs/src/shrex/client-server.md
Outdated
| - **NOT FOUND**: Requested data is not available | ||
| - **INTERNAL ERROR**: Server encountered an error | ||
|
|
||
| 2. **Data (if OK)**: The actual requested data |
There was a problem hiding this comment.
also include non-incl proof if ND not found
specs/src/shrex/client-server.md
Outdated
|
|
||
| - Connection failures | ||
| - Timeouts | ||
| - Invalid data |
There was a problem hiding this comment.
meaning invalid data sent back from server?
walldiss
left a comment
walldiss
left a comment
There was a problem hiding this comment.
Needs to add:
- transport protocol spec (libp2p streaming)
- message flow. Status message definition and proto. Error model in status message
- reference to shwap spec defining encoding and payload of requests and responses
- peer manager integration, reference to peer manager spec
I haven't added this spec yet. My idea was to add it when I will be merging all specs into a single.
Client-Server does not interact with peer manager, but Getter does. I will update spec with Additionally, I can add a list of available endpoints |
| - Retrieving data from local storage | ||
| - Sending responses back to clients | ||
|
|
||
| ### Request Handling |
There was a problem hiding this comment.
Actually false. Server sends "OK" along with non-inclusion proof
4 participants
Rendered