Skip to content

Fix for SQS transport deadlock#2479

Open
rlaunch wants to merge 4 commits intocelery:mainfrom
rlaunch:main
Open

Fix for SQS transport deadlock#2479
rlaunch wants to merge 4 commits intocelery:mainfrom
rlaunch:main

Conversation

@rlaunch
Copy link
Contributor

@rlaunch rlaunch commented Mar 5, 2026

This PR addresses a deadlock in the SQS fanout module which caused fanout queue _queue_bind calls to hang indefinitely. These issues were missed by existing unit tests as they were run in isolation.

Parts of the SNS module have been refactored to improve maintainability, and locks are held lower down the stack when initialise_exchange is called. As well as this, improvements have been made to SNS subscription error handling for consistency.

Integration tests have been added for the SNS module to catch issues like this in future.

Ryan Launchbury and others added 3 commits March 5, 2026 09:29
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.23%. Comparing base (3633f91) to head (b9d6822).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2479      +/-   ##
==========================================
- Coverage   82.24%   82.23%   -0.02%     
==========================================
  Files          79       79              
  Lines       10086    10080       -6     
  Branches     1153     1150       -3     
==========================================
- Hits         8295     8289       -6     
  Misses       1589     1589              
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy requested review from auvipy and Copilot March 5, 2026 18:19
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add extra integration tests for this as well?

@auvipy auvipy added this to the 5.7.0 milestone Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rlaunch
Copy link
Contributor Author

rlaunch commented Mar 6, 2026

is it possible to add extra integration tests for this as well?

Which module or method did you want more integration tests for?

Best,
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants