Open
Conversation
…ed integration tests to catch issues like this again in future.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
==========================================
- Coverage 82.24% 82.23% -0.02%
==========================================
Files 79 79
Lines 10086 10080 -6
Branches 1153 1150 -3
==========================================
- Hits 8295 8289 -6
Misses 1589 1589
Partials 202 202 ☔ View full report in Codecov by Sentry. |
auvipy
requested changes
Mar 5, 2026
Member
auvipy
left a comment
There was a problem hiding this comment.
is it possible to add extra integration tests for this as well?
Contributor
Author
Which module or method did you want more integration tests for? Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a deadlock in the SQS fanout module which caused fanout queue
_queue_bindcalls to hang indefinitely. These issues were missed by existing unit tests as they were run in isolation.Parts of the SNS module have been refactored to improve maintainability, and locks are held lower down the stack when
initialise_exchangeis called. As well as this, improvements have been made to SNS subscription error handling for consistency.Integration tests have been added for the SNS module to catch issues like this in future.