Skip to content

Implement missing _delete() method of filesystem.Channel#2437

Closed
WojciechMigda wants to merge 2 commits intocelery:mainfrom
WojciechMigda:transport-filesystem-channel-delete
Closed

Implement missing _delete() method of filesystem.Channel#2437
WojciechMigda wants to merge 2 commits intocelery:mainfrom
WojciechMigda:transport-filesystem-channel-delete

Conversation

@WojciechMigda
Copy link
Copy Markdown

@WojciechMigda WojciechMigda commented Jan 2, 2026

As of now, Channel class of filesystem transport does not have a _delete method. It prevents queues from being removed from an associated exchange. This PR intents to remedy that.

@WojciechMigda WojciechMigda force-pushed the transport-filesystem-channel-delete branch from 61c569a to 432eecf Compare January 2, 2026 22:25
auvipy
auvipy requested changes Jan 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, also add appropriate tests

@Nusnus Nusnus marked this pull request as draft January 4, 2026 20:40
@WojciechMigda WojciechMigda force-pushed the transport-filesystem-channel-delete branch from 432eecf to 04692de Compare January 22, 2026 19:55
@WojciechMigda
Copy link
Copy Markdown
Author

WojciechMigda commented Jan 22, 2026

I've fixed missing call to super()._delete in _delete, added code testing queue deletion in test_produce_consume, added cleanup code for created temporary folders in teardown_methods, fixed leaking queue bindings in broker state between testcases.

Nusnus and others added 2 commits January 22, 2026 21:04
@WojciechMigda WojciechMigda force-pushed the transport-filesystem-channel-delete branch from 501ca27 to 9217e06 Compare January 22, 2026 20:04
@WojciechMigda
Copy link
Copy Markdown
Author

WojciechMigda commented Feb 28, 2026

Is there anything I can do with this PR?

@auvipy
Copy link
Copy Markdown
Member

auvipy commented Feb 28, 2026

why you closed it?

@WojciechMigda
Copy link
Copy Markdown
Author

WojciechMigda commented Feb 28, 2026

There's some kind of trigger that closes it. It happened twice, if I remember it correctly both times after I force-pushed squeezed changes to my branch, so I assumed that this is something that is part of your CI/PR setup.

@WojciechMigda
Copy link
Copy Markdown
Author

WojciechMigda commented Feb 28, 2026

Oh, I can't re-open it because the button is grayed out with a hint that it's because of the branch being force-pushed.

@WojciechMigda
Copy link
Copy Markdown
Author

WojciechMigda commented Feb 28, 2026 •
edited
Loading

I'll try to open another PR. #2470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auvipy auvipy auvipy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WojciechMigda @auvipy @Nusnus