Conversation
Oytrik
requested review from
TristonianJones and
bansalkunal-google
and removed request for
bansalkunal-google
| bazel_dep( | ||
| name = "rules_proto", | ||
| version = "7.0.2", | ||
| ) |
Collaborator
There was a problem hiding this comment.
Is this a random version number or have some reference to rules_proto?
Collaborator
Author
There was a problem hiding this comment.
That was one of the latest version of the library available
https://registry.bazel.build/modules/rules_proto
|
|
||
| **Example Usage:** | ||
|
|
||
| Assuming you have a file named `my_ruleset.txt` with content in the `VendorRulesetCollection` format: |
Collaborator
There was a problem hiding this comment.
[nit] file name: my_ruleset.textproto?
| fs.StringVar(&o.file, "file", "", "File containing CEL expressions representing the Cloud Armor rule") | ||
| fs.StringVar(&o.outputFormat, "output_format", "", "output format (textproto, binarypb)") | ||
| fs.StringVar(&o.version, "version", "VCurrent", "valid versions (VCurrent, VNext)") | ||
| fs.StringVar(&o.textproto, "textproto", "", "File containing the VendorRulesetCollection ruleset textproto") |
Collaborator
There was a problem hiding this comment.
"File containing the rulesets as proto defined in VendorRulesetCollection"
| return parseErr | ||
| } | ||
|
|
||
| verboseLog(verbose, "Successfully validated vendor ruleset") |
Collaborator
There was a problem hiding this comment.
This is only a single rule.
Let's print it irrespective of verbose option.
bansalkunal-google
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce -textproto flag to allow testing string conversion into required proto.