feat: implement automated security audit script for Wasm files (#274)#280
Open
Danielodingz wants to merge 2 commits into
Open
feat: implement automated security audit script for Wasm files (#274)#280Danielodingz wants to merge 2 commits into
Danielodingz wants to merge 2 commits into
Conversation
|
@Danielodingz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Hey @Ceejaytech25 please check PR and merge, Thanks |
Contributor
Author
|
Hey @Ceejaytech25 please check PR and merge, Thanks you |
1 similar comment
Contributor
Author
|
Hey @Ceejaytech25 please check PR and merge, Thanks you |
Contributor
Author
|
Hey @Ceejaytech25 please merge this PR |
Contributor
Author
|
@Ceejaytech25 please merge now |
Contributor
Author
|
@Ceejaytech25 please merge |
Contributor
|
Nice implementation, lgtm! |
Contributor
|
@Danielodingz , pls resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
Feat: Implement automated security audit script for Wasm files
Description
This PR resolves issue #274 by introducing an automated security audit script that scans Soroban Wasm files for known vulnerabilities and suspicious patterns using
soroban-analyzerduring every CI build.Changes Made
scripts/security_audit.sh: A robust, ShellCheck-compliant bash script that:.wasmfiles within the project.soroban-analyzeron the discovered Wasm targets for deep static analysis.unsafe {blocks andenv.panicusages..github/workflows/rust.yml: Integrated the script into the rust CI pipeline as theRun Security Auditstep, ensuring it runs reliably during CI while strictly adhering to merge-safe constraints.Validation
shellcheckstandards (handles empty arrays, buffers output safely usingwhile read -r).0if Wasm files haven't been built yet (to avoid breaking CI pipelines unnecessarily).