feat(router): pass next navigation location to blocker callback #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cedarjs canceled.
|
mgramigna
commented
Jan 15, 2026
Comment on lines
+71
to
+72
| // FIXME: for navigating back, we don't have the next location info | ||
| processBlockers(0, performBack, '') |
Author
There was a problem hiding this comment.
@Tobbe any thoughts on a sensible approach here when we're going back? Don't see an obvious way to access the previous location to pass in to the callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we only want to block navigation if you are navigating away from a specific "root path".
E.g.
/a/b -> /a/cis ok, but/a/b -> /dis notThis PR allows you to define a function instead of just a boolean for determining if the blocker should activate, where
nextLocationis passed in to that callback functionPutting this in draft to start as I'm unsure what to do about handling
navigation.back(), couldn't see an obvious way to peek the previous location of the router and pass it through