Use vim-ruby syntax highlighting for yml files in Rails applications
#72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue with `yml` files as `vim-rails` is changing its file types to `eruby.yaml`(https://github.com/tpope/vim-rails/blob/b0a5c76f86ea214ade36ab0b811e730c3f0add67/plugin/rails.vim#L111-L114) so `treesitter-yaml` is not picking them as `yaml` files and thus its syntax highlighting is not enabled. We could simply register the `yaml` language for the `eruby.yaml` filetype in treesitter, but the syntax highlighting from treesitter doesn't takes the embedded ruby into account (it just considers them as strings), so this commits goes a step forward and disables syntax highlighting for `treesitter-yaml`. (Note that we are still linking `treesitter-yaml` to the `eruby.yaml` so that it considers them `yaml` files and thus not highlights them, allowing `vim-rails` syntax highlighting instead)
santiagorodriguez96
changed the title
vim-rails syntax highlighting for yaml filesvim-ruby syntax highlighting for yaml files
santiagorodriguez96
changed the title
vim-ruby syntax highlighting for yaml filesvim-ruby syntax highlighting for yaml files in Rails applications
santiagorodriguez96
changed the title
vim-ruby syntax highlighting for yaml files in Rails applicationsvim-ruby syntax highlighting for yml files in Rails applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with
ymlfiles asvim-railsis changing its file types toeruby.yaml(https://github.com/tpope/vim-rails/blob/b0a5c76f86ea214ade36ab0b811e730c3f0add67/plugin/rails.vim#L111-L114) sotreesitter-yamlis not picking them asyamlfiles and thus the files don't get syntax highlight'ed.We could simply register the
yamllanguage for theeruby.yamlfiletype in treesitter, but the syntax highlighting from treesitter doesn't takes the embedded ruby into account (it just considers them as strings), so this commits goes a step forward and disables syntax highlighting fortreesitter-yaml.(Note that we are still linking
treesitter-yamlto theeruby.yamlso that it considers themyamlfiles and thus not highlights them, allowingvim-rubysyntax highlighting instead)