Skip to content

fix educe bounds#1410

Merged
cdisselkoen merged 3 commits intomainfrom
cdisselkoen/educe-fork
Jan 6, 2025
Merged

fix educe bounds#1410
cdisselkoen merged 3 commits intomainfrom
cdisselkoen/educe-fork

Conversation

@cdisselkoen
Copy link
Copy Markdown
Contributor

Description of changes

Fixes bounds on educe-derived PartialOrd and Ord for Type and TypeVariant, and adds a test that Type<RawName> and Type<InternalName> are both Ord. Due to an apparent bug (?) in educe, this also changes cedar-policy-validator to depend on my fork of educe rather than the crates.io release of educe; I opened a PR to educe at magiclen/educe#35.

Issue #, if available

No issue #, but this should fix the CI failure in cedar-policy/cedar-spec#510

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen merged commit f2c21af into main Jan 6, 2025
@cdisselkoen cdisselkoen deleted the cdisselkoen/educe-fork branch January 6, 2025 16:55
@john-h-kastner-aws
Copy link
Copy Markdown
Contributor

For future reference: The PR text is out of date f75b972 was able to remove the dep on the fork

benelser pushed a commit to benelser/cedar that referenced this pull request Jan 16, 2026
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants