Lean: Add parsing for duration in the datetime extension#471
Merged
adpaco-aws merged 8 commits intocedar-policy:mainfrom Nov 25, 2024
Merged
Lean: Add parsing for duration in the datetime extension#471adpaco-aws merged 8 commits intocedar-policy:mainfrom
duration in the datetime extension#471adpaco-aws merged 8 commits intocedar-policy:mainfrom
Conversation
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Signed-off-by: Adrian Palacios <accorell@amazon.com>
afcdac8 to
0d87b61
Compare
emina
requested changes
Nov 9, 2024
Contributor
emina
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Left some comments.
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Signed-off-by: Adrian Palacios <accorell@amazon.com>
23c68ea to
ca2a459
Compare
emina
reviewed
Nov 22, 2024
Signed-off-by: Adrian Palacios <accorell@amazon.com>
emina
reviewed
Nov 25, 2024
Signed-off-by: Adrian Palacios <accorell@amazon.com>
emina
approved these changes
Nov 25, 2024
john-h-kastner-aws
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes
This PR adds parsing for
durationstrings in thedatetimeextension which is being introduced to the Lean models.We define a
parsefunction that attempts to parse adurationstring from the back. This helps us avoid an issue with respect to our previous forward version where this greedy approach leads to failures due to themunit being a substring of themsunit. The changes also include unit tests for parsing duration strings.Callouts
parsefunction fordatetimevalues, so I'm not sure what's the best way to name theparsein these changes. Do we want another namespace for thedurationdefinitions?