add authorization example to ro cedar rust hello world#202
Open
Swolebrain wants to merge 1 commit intocedar-policy:release/4.2.xfrom
Open
add authorization example to ro cedar rust hello world#202Swolebrain wants to merge 1 commit intocedar-policy:release/4.2.xfrom
Swolebrain wants to merge 1 commit intocedar-policy:release/4.2.xfrom
Conversation
Signed-off-by: Victor Moreno <morevct@amazon.com>
ff0ffaf to
85b06dc
Compare
john-h-kastner-aws
approved these changes
Dec 27, 2024
Contributor
john-h-kastner-aws
left a comment
There was a problem hiding this comment.
Looks good, though I'm not sure about the CI failures. The oopsla2024 build looks like it's failing for unrelated reasons. Does this build against main? (We should probably add the example for both 4.2 and main branches anyways)
Comment on lines
+483
to
+484
| let context_json_val = serde_json::json!({}); | ||
| let context = Context::from_json_value(context_json_val, None).unwrap(); |
Contributor
There was a problem hiding this comment.
Nicer API for this:
Suggested change
| let context_json_val = serde_json::json!({}); | |
| let context = Context::from_json_value(context_json_val, None).unwrap(); | |
| let context = Context::empty(); |
Comment on lines
+500
to
+501
| let entities_json = r#"[]"#; | ||
| let entities = Entities::from_json_str(entities_json, None).expect("entity parse error"); |
Contributor
There was a problem hiding this comment.
Suggested change
| let entities_json = r#"[]"#; | |
| let entities = Entities::from_json_str(entities_json, None).expect("entity parse error"); | |
| let entities = Entities::empty(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
just adds an example of using
is_authorizedto the cedar rust simple examples