Skip to content

Consistent action of conjugation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
switzel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Consistent action of conjugation #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c10a6da
Consistent action of conjugation
switzel Aug 30, 2023
4fa98cd
Transform.merge: corrected order of multiplication.
switzel Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hyperbolic/poincare/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ def identity():
def merge(*transfoms):
a,b,c,d = 1,0,0,1
conj = False
for i, trans in enumerate(transfoms):
for trans in reversed(transfoms):
a2,b2,c2,d2 = trans.abcd
if trans.conj:
a,b,c,d = (a.conjugate(), b.conjugate(), c.conjugate(),
Copy link
Copy Markdown
Contributor

@VascoSch92 VascoSch92 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the ( and ) here

d.conjugate())
conj = not conj
a,b,c,d = a*a2+c*b2, b*a2+d*b2, a*c2+c*d2, b*c2+d*d2
a,b,c,d = a2*a+b2*c, a2*b+b2*d, c2*a+d2*c, c2*b+d2*d
return Transform(a,b,c,d,conj=conj)
@staticmethod
Copy link
Copy Markdown
Contributor

@VascoSch92 VascoSch92 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave a space between two methods

def shift_origin(new_origin, new_x=None):
Expand Down