Skip to content

1703: Remove size unit variable#1719

Merged
SFJohnson24 merged 3 commits into
mainfrom
1703-remove-size-unit-variable
May 18, 2026
Merged

1703: Remove size unit variable#1719
SFJohnson24 merged 3 commits into
mainfrom
1703-remove-size-unit-variable

Conversation

@alexfurmenkov
Copy link
Copy Markdown
Collaborator

@alexfurmenkov alexfurmenkov commented May 5, 2026

No description provided.

@alexfurmenkov alexfurmenkov changed the title Remove size unit variable and related logic from dataset metadata han… 1703: Remove size unit variable May 5, 2026
@alexfurmenkov alexfurmenkov marked this pull request as ready for review May 15, 2026 16:35
Copy link
Copy Markdown
Collaborator

@SFJohnson24 SFJohnson24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR correctly addresses issue to remove size_unit as obsolete variable. No further traces of it or it's logic remain in engine

@SFJohnson24 SFJohnson24 merged commit 5de184d into main May 18, 2026
11 checks passed
@SFJohnson24 SFJohnson24 deleted the 1703-remove-size-unit-variable branch May 18, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove size_unit as it is a dead variable that isn't being used in get_dataset_metadata for LocalDataService.

2 participants