-
Notifications
You must be signed in to change notification settings - Fork 35
TIG use case #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
TIG use case #1556
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c1fb1c6
initial commit tig use case
SFJohnson24 eef8a1e
validation arg
SFJohnson24 42a83e9
use case test
SFJohnson24 72e7165
last test failure
SFJohnson24 5fdc1a0
readme
SFJohnson24 19f0707
report tests, update
SFJohnson24 e95273e
use case ruletester
SFJohnson24 fffcd8c
fix parsing issue
SFJohnson24 c6e7d70
update
SFJohnson24 8d898dd
Auto-updated branch with latest changes from main
SFJohnson24 f9f0e6b
Auto-updated branch with latest changes from main
SFJohnson24 f6afe96
Auto-updated branch with latest changes from main
SFJohnson24 b6e5621
Auto-updated branch with latest changes from main
SFJohnson24 ba241ba
Auto-updated branch with latest changes from main
SFJohnson24 b68a851
Auto-updated branch with latest changes from main
SFJohnson24 6bfe3f1
Auto-updated branch with latest changes from main
SFJohnson24 ab04890
Auto-updated branch with latest changes from main
SFJohnson24 ed0c5dc
Auto-updated branch with latest changes from main
SFJohnson24 e28ee24
Auto-updated branch with latest changes from main
SFJohnson24 4e831ae
Auto-updated branch with latest changes from main
SFJohnson24 4fd72d1
Auto-updated branch with latest changes from main
SFJohnson24 78693db
Merge branch 'main' into tig_custom
SFJohnson24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,7 +233,19 @@ def _validate_no_arguments(logger) -> None: | |
| "-ss", | ||
| "--substandard", | ||
| default=None, | ||
| help="CDISC Substandard to validate against", | ||
| type=click.Choice(["sdtm", "send", "adam", "cdash"], case_sensitive=False), | ||
| help="CDISC Substandard to validate against. Any of SDTM, SEND, ADaM, CDASH", | ||
| ) | ||
| @click.option( | ||
| "-uc", | ||
| "--use-case", | ||
| required=False, | ||
| default=None, | ||
| type=click.Choice(["INDH", "PROD", "NONCLIN", "ANALYSIS"], case_sensitive=True), | ||
| help=( | ||
| "CDISC TIG Use Case for scoping a TIG Validation." | ||
| "Any of INDH, PROD, NONCLIN, or ANALYSIS." | ||
| ), | ||
| ) | ||
| @click.option( | ||
| "-ct", | ||
|
|
@@ -368,7 +380,7 @@ def _validate_no_arguments(logger) -> None: | |
| ), | ||
| ) | ||
| @click.pass_context | ||
| def validate( | ||
| def validate( # noqa | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above--I wanted to keep validate as a single functional unit |
||
| ctx, | ||
| cache: str, | ||
| pool_size: int, | ||
|
|
@@ -380,6 +392,7 @@ def validate( | |
| standard: str, | ||
| version: str, | ||
| substandard: str, | ||
| use_case: str, | ||
| controlled_terminology_package: tuple[str], | ||
| output: str, | ||
| output_format: tuple[str], | ||
|
|
@@ -431,6 +444,12 @@ def validate( | |
|
|
||
| cache_path: str = os.path.join(os.path.dirname(__file__), cache) | ||
|
|
||
| if standard.lower() == "tig": | ||
| if not substandard or not use_case: | ||
| logger.error( | ||
| "Standard 'tig' requires both --substandard and --use-case to be specified." | ||
| ) | ||
| ctx.exit(2) | ||
| # Construct ExternalDictionariesContainer: | ||
| external_dictionaries = ExternalDictionariesContainer( | ||
| { | ||
|
|
@@ -474,6 +493,7 @@ def validate( | |
| standard, | ||
| version, | ||
| substandard, | ||
| use_case, | ||
| set(controlled_terminology_package), # avoiding duplicates | ||
| output, | ||
| set(output_format), # avoiding duplicates | ||
|
|
@@ -840,6 +860,7 @@ def test_validate(filetype): | |
| standard, | ||
| version, | ||
| None, | ||
| None, | ||
| set(), | ||
| output, | ||
| output_format, | ||
|
|
||
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please mention the reason for skipping the lint check here now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignoring complexity check to keep the conformance detail data as one function--it is not complex, it just needs to fill in each field of the conformance details