-
Notifications
You must be signed in to change notification settings - Fork 27
Add define_dataset_variable_order with OrderNumber sorting support (#791) #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RakeshBobba03
wants to merge
20
commits into
main
Choose a base branch
from
791-define-variable-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neXMLReaderFactory
RamilCDISC
approved these changes
Jan 21, 2026
Collaborator
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR adds define_dataset_variable_order to dataset contents check against define xml. The updates were validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring all relevant testing is updated.
- Ensuring new tests are added for define_dataset_variable_order.
- Running manual testing using CLI on positive datasets.
- Running manual testing using CLI on negative datasets.
- Running manual validation using dev editor on positive datasets.
- Running manual validation using dev on negative datasets.
- Covered cases like:
- when ordernumber is present
- when ordernumber is missing
- when only one ordernumber is missing
- when only one ordernumber is present
- when multiple ordernumbers are same
- when ordernumbers are in order in a row
- when a smaller ordernumber comes after a bigger ordernumber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#791 Implements
define_dataset_variable_ordermetadata variable that returns dataset variables ordered by OrderNumber when present in Define XML, otherwise falls back to XML document order. This adds the new field toextract_dataset_metadata()andextract_domain_metadata()methods in BaseDefineXMLReader, updates all relevant dataset builders to include the field in their output, adds schema validation in MetaVariables.json, and includes comprehensive unit tests. The sorting logic is centralized in_get_ordered_dataset_variables()method following DRY principles.