Skip to content

Conversation

@RakeshBobba03
Copy link
Collaborator

Issue #635 : Add documentation for Executability
Adds Executability documentation. Updates CORE-base.json to convert the Executability field from a simple enum to an anyOf pattern with markdownDescription for each option (Fully Executable, Not Executable, Partially Executable, Partially Executable - Possible Overreporting, Partially Executable - Possible Underreporting), enabling intellisense descriptions in the rule editor. Creates Executability.md in resources/schema/ with documentation for all Executability options, including examples and notes that Executability is informational metadata. Updates conformance-rules-editor/docs/executability.md to use the include pattern, pulling content from the cdisc-rules-engine repo to match the pattern used by other schema documentation files.

@RakeshBobba03 RakeshBobba03 linked an issue Jan 1, 2026 that may be closed by this pull request
@RakeshBobba03 RakeshBobba03 marked this pull request as ready for review January 1, 2026 23:45
Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the editor locally with schema url pointing to core-base.json of this branch, when i hover over executability, documentation appears but the heading where all options are supposed to be visible is empty and shows only pipe symbols. Please see the attached screenshot. Please let me know i have missed something in local execution.

Image

@@ -0,0 +1,35 @@
## Executability
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make its size heading 1, for consistency with pattern of other documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed from markdownDescription to title for individual enum values and I think it should resolve the || issue, and also I updated the heading size. If you run into any issues, please let me know.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds documentation for executability key in rule yaml. The changes were validated by:

  1. Reviewing the PR code for any unwanted changes or comment.
  2. Reviewing the PR logic in accordance with AC.
  3. Ensuring all testing pass.
  4. Running manual testing using local editor.
  5. Confirming intellisense shows all option for executability.
  6. Confirming hovering shows correct details and help for executability.
  7. Ensuring this documentation does not break execution of rule in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There should be documentation for Executability

4 participants