Skip to content

Conversation

@RakeshBobba03
Copy link
Collaborator

This PR for Issue #710 adds the CORE logo as the executable icon for PyInstaller builds and updates the README to display the CORE logo instead of the CDISC logo. The icon file (CORE_logo_sm.ico) has been added to resources/assets/ and integrated into all build configurations: Dockerfile.build, GitHub Actions workflows (build-binary.yml), and README documentation (PyInstaller commands for both Linux and Windows). The README logo at the top has been updated to use the CORE logo image (CORE_logo_sm.png). These changes ensure that future releases will display the CORE logo on Windows executables and in the repository README.

@RakeshBobba03 RakeshBobba03 linked an issue Dec 28, 2025 that may be closed by this pull request
@RakeshBobba03 RakeshBobba03 marked this pull request as ready for review December 28, 2025 23:15
@RakeshBobba03 RakeshBobba03 marked this pull request as draft December 30, 2025 16:53
@RakeshBobba03 RakeshBobba03 marked this pull request as ready for review January 1, 2026 23:46
Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the Build custom executable workflow too?

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the custom executable build workflow and downloaded the zip. The executable in the zip did not have the provided icon. You can download the zip from here https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/20699099226

I tried locally too on a mac. The executables did not have the icon.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the commands in readme.md to show for mac too and i ran the workflow for linux here https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/20829577911

The core executable still does not show the icon. You can download the zip from the link above.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds core icon to the executables created through workflows and manually. The PR was validated by:

  1. Ensuring all relevant workflows were updated.
  2. Ensuring all documentation was updated.
  3. Ensuring windows, mac and linux all were converted in updates.
  4. Tested the linux executable by running build_version.yml workflow.
  5. Tested mac and windows by building executables locally.

Note: For linux the icon may not be visible because file managers there typically display generic icons for executables. For mac add '--windowed' to the command to create core.app, as mac shows icon only on .app.

@RamilCDISC RamilCDISC merged commit 48a9cc6 into main Jan 9, 2026
11 checks passed
@RamilCDISC RamilCDISC deleted the 710-executable's-icon branch January 9, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Executable's icon

3 participants