-
Notifications
You must be signed in to change notification settings - Fork 27
Ap library #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ap library #1497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
approved these changes
Jan 2, 2026
Collaborator
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR updates the handling for AP datasets. The validation was done by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensure all relevant testing is updated.
- Ensuring the new tests cover edge cases.
- Running manual testing using dev rule editor on negative datasets.
- Running manual testing on dev rule editor using positive datasets.
- Matching the allowed variables with library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for AP-- domains, mainly SQAP as well as AP--. The logic to get the associated persons, replace USUBJID for APID, and grab the remaining domain variables, then merge. It also adds a test suite for base domains, SQAP, SUPP--, as well as AP-- domains.
to test: run cg0013 on the AP datasets in dev folder.
This pull request refactors how variable metadata is retrieved and handled for SDTM domains, especially for special cases like SUPP, SQ, and AP (Associated Persons) domains. It removes hardcoded logic for required variables, centralizes domain handling, and improves support for AP domains by dynamically merging Associated Persons variables when needed. Additionally, it updates the logic for determining variable permissibility and aligns unit tests with the new approach.
Core logic and metadata handling improvements:
Refactored
get_variables_metadata_from_standardandget_variables_metadata_from_standard_modelinsdtm_utilities.pyto handle AP (Associated Persons), SUPP, and SQ domains more robustly by dynamically merging AP variables and removing hardcoded checks for required variables. This includes sorting and filtering logic for identifiers and updating how wildcards are replaced in variable names. [1] [2] [3] [4] [5] [6]Updated
base_dataset_builder.pyandbase_operation.pyto consistently useunsplit_namefor domain resolution, removing special-case logic for APREL and SUPP domains. This centralizes domain handling and ensures consistency across the codebase. [1] [2]Permissibility and required variables logic:
REQUIRED_MODEL_VARIABLESandSEQ_VARIABLEfrompermissibility.pyand related logic inbase_operation.py. The permissibility for variables is now determined directly from metadata, improving maintainability and flexibility. [1] [2] [3]Testing and documentation:
Documentation and comments:
unsplit_nameand providing default values in the example environment file. [1] [2]