1308: Fix grouping in max_date operation #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 1308-operation-max_date-doesnt-work-when-group-is-specified
…into 1308-operation-max_date-doesnt-work-when-group-is-specified
…into 1308-operation-max_date-doesnt-work-when-group-is-specified
…ork-when-group-is-specified' into 1308-operation-max_date-doesnt-work-when-group-is-specified
RamilCDISC
requested changes
Dec 11, 2025
cdisc_rules_engine/rules_engine.py
Outdated
| dataset_metadata=dataset_metadata, | ||
| datasets=datasets, | ||
| dataset_path=dataset_metadata.full_path, | ||
| # dataset_path=dataset_metadata.original_path or dataset_metadata.full_path, |
Collaborator
There was a problem hiding this comment.
Could you please remove this comment?
| PandasDataset, | ||
| ["USUBJID"], | ||
| ), | ||
| ({"dates": [None, None]}, "", DaskDataset), |
Collaborator
There was a problem hiding this comment.
Could you please add a grouping test case using Dask Dataset too?
…into 1308-operation-max_date-doesnt-work-when-group-is-specified
RamilCDISC
approved these changes
Dec 22, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR fixes the grouping for max_date operation. The PR was validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR in accordance with AC.
- Validating all unit and regression tests pass.
- Ensuring all related testing is updated.
- Ensuring updated testing covers cases for both PANDAS and DASK.
- Running manual testing using dev editor using positive datasets.
- Running manual testing using dev editor using negative datasets.
- Ensuring edge cases of missing values and nulls.
RamilCDISC
deleted the
1308-operation-max_date-doesnt-work-when-group-is-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.