Skip to content

remove file extension #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SFJohnson24 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove file extension #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5200a62
remove file extension
SFJohnson24 May 18, 2026
36888c1
uppercase
SFJohnson24 May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/scripts/convert_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def convert_nonusdm(issue_details: list) -> tuple[list[str], list[tuple]]:
header = ["Dataset", "Record", "Variable", "Value"]
rows = []
for issue in issue_details:
dataset = issue.get("dataset", "")
Copy link
Copy Markdown
Collaborator

@gerrycampion gerrycampion May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the csv coming from in the first place? The data in sharepoint doesn't have csv extensions...

Copy link
Copy Markdown
Collaborator Author

@SFJohnson24 SFJohnson24 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert() on line 58 in this file--takes the json results output, converts to csv

Copy link
Copy Markdown
Collaborator

@gerrycampion gerrycampion May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding logic here, can you update the logic at the source that converts these from ae.xpt to ae.csv?

dataset = issue.get("dataset", "").removesuffix(".csv")
record = str(issue.get("row", ""))
variables = issue.get("variables") or []
values = issue.get("values") or []
Expand Down
12 changes: 6 additions & 6 deletions Published/CORE-000001/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Dataset,Record,Variable,Value
ie.csv,1,IECAT,INCLUSION
ie.csv,1,IEORRES,Y
ie.csv,2,IECAT,INCLUSION
ie.csv,2,IEORRES,Yes
ie.csv,3,IECAT,INCLUSION
ie.csv,3,IEORRES,Nope
IE,1,IECAT,INCLUSION
IE,1,IEORRES,Y
IE,2,IECAT,INCLUSION
IE,2,IEORRES,Yes
IE,3,IECAT,INCLUSION
IE,3,IEORRES,Nope
54 changes: 27 additions & 27 deletions Published/CORE-000003/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
Dataset,Record,Variable,Value
TR.csv,0,TRLOC,
TR.csv,1,TRLOC,LIVER
TR.csv,2,TRLOC,KIDNEY
TR.csv,3,TRLOC,CERVICAL LYMPH NODE
TR.csv,4,TRLOC,SKIN OF THE TRUNK
TR.csv,5,TRLOC,LIVER
TR.csv,6,TRLOC,KIDNEY
TR.csv,7,TRLOC,CERVICAL LYMPH NODE
TR.csv,8,TRLOC,SKIN OF THE TRUNK
TR.csv,9,TRLOC,SKIN OF THE TRUNK
TR.csv,10,TRLOC,LIVER
TR.csv,11,TRLOC,KIDNEY
TR.csv,12,TRLOC,CERVICAL LYMPH NODE
TR.csv,13,TRLOC,SKIN OF THE TRUNK
TR.csv,14,TRLOC,
TR.csv,15,TRLOC,
TR.csv,16,TRLOC,
TR.csv,17,TRLOC,
TR.csv,18,TRLOC,
TR.csv,19,TRLOC,
TR.csv,20,TRLOC,
TR.csv,21,TRLOC,THYROID GLAND
TR.csv,22,TRLOC,CEREBELLUM
TR.csv,23,TRLOC,THYROID GLAND
TR.csv,24,TRLOC,CEREBELLUM
TR.csv,25,TRLOC,THYROID GLAND
TR.csv,26,TRLOC,CEREBELLUM
TR,0,TRLOC,
TR,1,TRLOC,LIVER
TR,2,TRLOC,KIDNEY
TR,3,TRLOC,CERVICAL LYMPH NODE
TR,4,TRLOC,SKIN OF THE TRUNK
TR,5,TRLOC,LIVER
TR,6,TRLOC,KIDNEY
TR,7,TRLOC,CERVICAL LYMPH NODE
TR,8,TRLOC,SKIN OF THE TRUNK
TR,9,TRLOC,SKIN OF THE TRUNK
TR,10,TRLOC,LIVER
TR,11,TRLOC,KIDNEY
TR,12,TRLOC,CERVICAL LYMPH NODE
TR,13,TRLOC,SKIN OF THE TRUNK
TR,14,TRLOC,
TR,15,TRLOC,
TR,16,TRLOC,
TR,17,TRLOC,
TR,18,TRLOC,
TR,19,TRLOC,
TR,20,TRLOC,
TR,21,TRLOC,THYROID GLAND
TR,22,TRLOC,CEREBELLUM
TR,23,TRLOC,THYROID GLAND
TR,24,TRLOC,CEREBELLUM
TR,25,TRLOC,THYROID GLAND
TR,26,TRLOC,CEREBELLUM
54 changes: 27 additions & 27 deletions Published/CORE-000003/negative/02/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
Dataset,Record,Variable,Value
TR.csv,0,TRLOC,
TR.csv,1,TRLOC,
TR.csv,2,TRLOC,
TR.csv,3,TRLOC,
TR.csv,4,TRLOC,
TR.csv,5,TRLOC,
TR.csv,6,TRLOC,
TR.csv,7,TRLOC,
TR.csv,8,TRLOC,
TR.csv,9,TRLOC,
TR.csv,10,TRLOC,
TR.csv,11,TRLOC,
TR.csv,12,TRLOC,
TR.csv,13,TRLOC,
TR.csv,14,TRLOC,
TR.csv,15,TRLOC,
TR.csv,16,TRLOC,
TR.csv,17,TRLOC,
TR.csv,18,TRLOC,
TR.csv,19,TRLOC,
TR.csv,20,TRLOC,
TR.csv,21,TRLOC,
TR.csv,22,TRLOC,
TR.csv,23,TRLOC,
TR.csv,24,TRLOC,
TR.csv,25,TRLOC,
TR.csv,26,TRLOC,
TR,0,TRLOC,
TR,1,TRLOC,
TR,2,TRLOC,
TR,3,TRLOC,
TR,4,TRLOC,
TR,5,TRLOC,
TR,6,TRLOC,
TR,7,TRLOC,
TR,8,TRLOC,
TR,9,TRLOC,
TR,10,TRLOC,
TR,11,TRLOC,
TR,12,TRLOC,
TR,13,TRLOC,
TR,14,TRLOC,
TR,15,TRLOC,
TR,16,TRLOC,
TR,17,TRLOC,
TR,18,TRLOC,
TR,19,TRLOC,
TR,20,TRLOC,
TR,21,TRLOC,
TR,22,TRLOC,
TR,23,TRLOC,
TR,24,TRLOC,
TR,25,TRLOC,
TR,26,TRLOC,
4 changes: 2 additions & 2 deletions Published/CORE-000004/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Dataset,Record,Variable,Value
EC.csv,7,ECDOSE,0
EC.csv,7,ECOCCUR,N
EC,7,ECDOSE,0
EC,7,ECOCCUR,N
6 changes: 3 additions & 3 deletions Published/CORE-000006/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Dataset,Record,Variable,Value
DM.csv,0,DTHFL,N
DM.csv,1,DTHFL,U
DM.csv,3,DTHFL,N
DM,0,DTHFL,N
DM,1,DTHFL,U
DM,3,DTHFL,N
12 changes: 6 additions & 6 deletions Published/CORE-000007/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Dataset,Record,Variable,Value
DM.csv,2,DTHDTC,2018-06-10
DM.csv,2,DTHFL,
DM.csv,2,USUBJID,015246-099-0000-00002
DM.csv,3,DTHDTC,2018-09-04
DM.csv,3,DTHFL,N
DM.csv,3,USUBJID,015246-099-0000-00003
DM,2,DTHDTC,2018-06-10
DM,2,DTHFL,
DM,2,USUBJID,015246-099-0000-00002
DM,3,DTHDTC,2018-09-04
DM,3,DTHFL,N
DM,3,USUBJID,015246-099-0000-00003
4 changes: 2 additions & 2 deletions Published/CORE-000007/negative/02/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Dataset,Record,Variable,Value
dm.csv,3,DTHDTC,2018-12-11
dm.csv,3,DTHFL,
DM,3,DTHDTC,2018-12-11
DM,3,DTHFL,
8 changes: 4 additions & 4 deletions Published/CORE-000008/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Dataset,Record,Variable,Value
DM.csv,0,DTHFL,
DM.csv,0,SSSTRESC,DEAD
DM.csv,1,DTHFL,N
DM.csv,1,SSSTRESC,DEAD
DM,0,DTHFL,
DM,0,SSSTRESC,DEAD
DM,1,DTHFL,N
DM,1,SSSTRESC,DEAD
4 changes: 2 additions & 2 deletions Published/CORE-000009/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Dataset,Record,Variable,Value
SE.csv,5,ELEMENT,Unplanned Drug B
SE.csv,5,ETCD,UNPLAN
SE,5,ELEMENT,Unplanned Drug B
SE,5,ETCD,UNPLAN
36 changes: 18 additions & 18 deletions Published/CORE-000010/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
Dataset,Record,Variable,Value
DM.csv,0,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM.csv,1,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM.csv,2,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM.csv,4,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM.csv,5,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM.csv,6,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM.csv,9,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM.csv,10,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM.csv,13,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM.csv,15,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM.csv,16,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM.csv,17,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA.csv,2,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
TA.csv,3,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
TA.csv,4,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA.csv,5,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA.csv,6,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA.csv,7,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,0,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM,1,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM,2,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,4,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,5,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM,6,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,9,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,10,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,13,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
DM,15,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM,16,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
DM,17,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA,2,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
TA,3,ARMCD,ZANOMALINE_LOW_DOSE_54_mg
TA,4,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA,5,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA,6,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
TA,7,ARMCD,ZANOMALINE_HIGH_DOSE_81_mg
12 changes: 6 additions & 6 deletions Published/CORE-000011/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Dataset,Record,Variable,Value
ie.csv,1,IECAT,EXCLUSION
ie.csv,1,IEORRES,N
ie.csv,2,IECAT,EXCLUSION
ie.csv,2,IEORRES,
ie.csv,3,IECAT,EXCLUSION
ie.csv,3,IEORRES,NOT DONE
IE,1,IECAT,EXCLUSION
IE,1,IEORRES,N
IE,2,IECAT,EXCLUSION
IE,2,IEORRES,
IE,3,IECAT,EXCLUSION
IE,3,IEORRES,NOT DONE
2 changes: 1 addition & 1 deletion Published/CORE-000012/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Dataset,Record,Variable,Value
AE.csv,,AEOCCUR,Y
AE,,AEOCCUR,Y
2 changes: 1 addition & 1 deletion Published/CORE-000012/negative/02/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Dataset,Record,Variable,Value
AE.csv,,AEOCCUR,Y
AE,,AEOCCUR,Y
26 changes: 13 additions & 13 deletions Published/CORE-000013/negative/01/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
Dataset,Record,Variable,Value
AE.csv,0,AESTAT,NOT DONE
AE.csv,1,AESTAT,NOT DONE
AE.csv,2,AESTAT,NOT DONE
AE.csv,3,AESTAT,NOT DONE
AE.csv,4,AESTAT,
AE.csv,5,AESTAT,
AE.csv,6,AESTAT,NOT DONE
AE.csv,7,AESTAT,
AE.csv,8,AESTAT,
AE.csv,9,AESTAT,
AE.csv,10,AESTAT,NOT DONE
AE.csv,11,AESTAT,
AE.csv,12,AESTAT,
AE,0,AESTAT,NOT DONE
AE,1,AESTAT,NOT DONE
AE,2,AESTAT,NOT DONE
AE,3,AESTAT,NOT DONE
AE,4,AESTAT,
AE,5,AESTAT,
AE,6,AESTAT,NOT DONE
AE,7,AESTAT,
AE,8,AESTAT,
AE,9,AESTAT,
AE,10,AESTAT,NOT DONE
AE,11,AESTAT,
AE,12,AESTAT,
26 changes: 13 additions & 13 deletions Published/CORE-000013/negative/02/results/results.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
Dataset,Record,Variable,Value
AE.csv,0,AESTAT,
AE.csv,1,AESTAT,
AE.csv,2,AESTAT,
AE.csv,3,AESTAT,
AE.csv,4,AESTAT,
AE.csv,5,AESTAT,
AE.csv,6,AESTAT,NOT DONE
AE.csv,7,AESTAT,
AE.csv,8,AESTAT,
AE.csv,9,AESTAT,
AE.csv,10,AESTAT,
AE.csv,11,AESTAT,
AE.csv,12,AESTAT,
AE,0,AESTAT,
AE,1,AESTAT,
AE,2,AESTAT,
AE,3,AESTAT,
AE,4,AESTAT,
AE,5,AESTAT,
AE,6,AESTAT,NOT DONE
AE,7,AESTAT,
AE,8,AESTAT,
AE,9,AESTAT,
AE,10,AESTAT,
AE,11,AESTAT,
AE,12,AESTAT,
Loading
Loading