Skip to content

feat: enable missing faceBlendshapes feature for ios #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devitcf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: enable missing faceBlendshapes feature for ios #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1167f37
feat: enable missing faceBlendshapes feature for ios
devitcf Feb 16, 2025
5d1c025
chore: bump dependency MediaPipeTasksVision to 0.10.13 which is the m…
devitcf Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ReactNativeMediaPipe.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Pod::Spec.new do |s|

s.source_files = "ios/**/*.{h,m,mm,swift}"

s.dependency "MediaPipeTasksVision", "0.10.12"
s.dependency "MediaPipeTasksVision", "0.10.13"
s.dependency "VisionCamera"

# Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
Expand All @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
install_modules_dependencies(s)
else
s.dependency "React-Core"

# Don't install the dependencies when we run `pod install` in the old architecture.
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
Expand All @@ -41,5 +41,5 @@ Pod::Spec.new do |s|
s.dependency "RCTTypeSafety"
s.dependency "ReactCommon/turbomodule/core"
end
end
end
end
3 changes: 2 additions & 1 deletion ios/facelandmarkdetection/FaceLandmarkDetectorHelper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class FaceLandmarkDetectorHelper: NSObject {
private var minTrackingConfidence: Float
private var optionsDelegate: Delegate
var modelPath: String

let handle: Int

// this is an unfortunate hack : we need to provide the client with the size of the
Expand Down Expand Up @@ -73,6 +73,7 @@ class FaceLandmarkDetectorHelper: NSObject {
faceLandmarkerOptions.minTrackingConfidence = self.minTrackingConfidence
faceLandmarkerOptions.baseOptions.modelAssetPath = self.modelPath
faceLandmarkerOptions.baseOptions.delegate = self.optionsDelegate
faceLandmarkerOptions.outputFaceBlendshapes = true
if runningMode == .liveStream {
faceLandmarkerOptions.faceLandmarkerLiveStreamDelegate = self
}
Expand Down
Loading