Split password-instances into multiple packages (#1) #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackheaven
force-pushed
the
refactor/split-password-instances
branch
7 times, most recently
from
87f6ea3 to
1609803
Compare
This was referenced Oct 5, 2025
Collaborator
|
Did you build with |
Vlix
requested changes
Oct 7, 2025
Collaborator
Vlix
left a comment
Vlix
left a comment
There was a problem hiding this comment.
Not bad. Seems like what we were looking for.
blackheaven
force-pushed
the
refactor/split-password-instances
branch
from
1609803 to
66379d8
Compare
Contributor
Author
yes :) |
Vlix
requested changes
Oct 7, 2025
blackheaven
force-pushed
the
refactor/split-password-instances
branch
6 times, most recently
from
1ed4038 to
e928900
Compare
Vlix
reviewed
Oct 10, 2025
blackheaven
force-pushed
the
refactor/split-password-instances
branch
3 times, most recently
from
d6332e6 to
10dd5f5
Compare
blackheaven
force-pushed
the
refactor/split-password-instances
branch
2 times, most recently
from
f40f2dd to
aea7f48
Compare
blackheaven
force-pushed
the
refactor/split-password-instances
branch
from
aea7f48 to
d2277fe
Compare
Vlix
approved these changes
Oct 12, 2025
Collaborator
Vlix
left a comment
Vlix
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR 🙏 as always.
I'll wait on merging this and make an issue about all the steps for releasing this + the password-cli, plus the next PR; so me or cdepillabout can pick this up when we have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's mostly cut and paste.