-
Notifications
You must be signed in to change notification settings - Fork 16
Add documentation about the password-cli (#83)
#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I don't think the CI failure is related to my PR. |
|
Ah, yes. Not sure if I like the repetition of the |
|
Ah, nevermind. I've literally asked for that in the #83 issue. 🤦 I would like to also see the second part of the checkboxes of the issue's first post ticked in this PR: |
5f7bdee to
2daa749
Compare
Done :) |
|
@Vlix can you have another look please? |
password/src/Data/Password/Argon2.hs
Outdated
| You can use [password-cli](https://github.com/cdepillabout/password/tree/master/password-cli) to test it: | ||
| > $ password-cli check argon2 --hash "SOME-HASH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These kind of examples might also be better with single quotes '.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I have fixed it and the other ones
2daa749 to
00ea6cc
Compare
|
@Vlix thanks for you feedback, ready for a new review. |
Vlix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to be merged :)
I'll hold off on actually merging until publishing the password-cli to hackage. Don't want to reference it in documentation when it's not actually available.
A bit of documentation, let me know if you had something else in mind.