Open
Conversation
Collaborator
pcriadoperez
left a comment
pcriadoperez
left a comment
There was a problem hiding this comment.
Thanks for the contribution!!
I left some comments and also if possible I'd add a file for integrations tests
| return s | ||
| } | ||
|
|
||
| func (s *VipLoanInterestRateHistoryService) Do(ctx context.Context) (*VipLoanInterestRateHistoryResponse, error) { |
Collaborator
There was a problem hiding this comment.
I would seperate each service into it's own file to keep consistent with the repo
Author
There was a problem hiding this comment.
Would it be better to spilt these apis into 3 file like market data, user information and trade? I think split them into 12 files will be too much files
| @@ -0,0 +1,590 @@ | |||
| package binance | |||
|
|
|||
| import ( | |||
Collaborator
There was a problem hiding this comment.
I'd seperate to have one test file per service to keep consistent with the repo
| // ----- end simple earn service ----- | ||
|
|
||
| // ----- vip loan service ----- | ||
| func (c *Client) NewVipLoanService() *VipLoanService { |
Collaborator
There was a problem hiding this comment.
I'd list here all the services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is documented by VIP Loan
Notice: some of the result types is inconsistent with the document, so we use the actual type returned by binance API instead of the example response in the document, for example: CollateralData have 9 ranks instead of the 3 in document, and InterestRate & InterestRateHistory is using string timestamp instead of int