feat(client): add updateOrder and futuresUpdateOrder #692
Conversation
carlosmiei
commented
Dec 16, 2025
carlosmiei
commented
- relates to Feature request: Cancel an Existing Order and Send a New Order (TRADE) #582 (comment)
- todo add type
There was a problem hiding this comment.
Pull request overview
This PR adds two new order update methods to support Binance's order cancel/replace functionality: updateOrder for spot trading and futuresUpdateOrder for futures trading. These methods enable users to modify existing orders atomically, addressing the feature request in issue #582.
Key Changes:
- Added
updateOrdermethod that calls the/api/v3/order/cancelReplaceendpoint - Added
futuresUpdateOrdermethod that calls the/fapi/v1/orderPUT endpoint with placeholder logic for conditional orders
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // for now it is not supported | ||
| // const payloadCopy = { ...payload } | ||
| // delete payloadCopy.conditional | ||
| // return privCall('/fapi/v1/algoOrder', payloadCopy, 'PUT') |
There was a problem hiding this comment.
Commented-out code should be removed. If this functionality is planned for future implementation, consider creating a TODO comment or GitHub issue instead of leaving commented code in the codebase.
src/http-client.js
Outdated
|
|
||
| // Order endpoints | ||
| order: payload => order(privCall, payload, '/api/v3/order'), | ||
| updateOrder: payload => privCall('/api/v3/order/cancelReplace', payload, 'POST'), |
There was a problem hiding this comment.
The updateOrder endpoint lacks test coverage. Other order endpoints in test/orders.js have corresponding tests (e.g., orderTest, getOrder, cancelOrder). Consider adding tests for updateOrder to verify parameter handling, error cases, and successful order updates using the /api/v3/order/cancelReplace endpoint.
| futuresUpdateOrder: payload => { | ||
| if (payload && 'conditional' in payload) { | ||
| // for now it is not supported | ||
| // const payloadCopy = { ...payload } | ||
| // delete payloadCopy.conditional | ||
| // return privCall('/fapi/v1/algoOrder', payloadCopy, 'PUT') | ||
| } | ||
| return privCall('/fapi/v1/order', payload, 'PUT') | ||
| }, |
There was a problem hiding this comment.
The futuresUpdateOrder endpoint lacks test coverage. Other futures order endpoints in test/futures.js have corresponding tests (e.g., futuresOrder, futuresGetOrder, futuresCancelOrder). Consider adding tests for futuresUpdateOrder to verify parameter handling, error cases, and successful order updates using the /fapi/v1/order PUT endpoint.
| futuresUpdateOrder: payload => { | ||
| if (payload && 'conditional' in payload) { | ||
| // for now it is not supported | ||
| // const payloadCopy = { ...payload } | ||
| // delete payloadCopy.conditional | ||
| // return privCall('/fapi/v1/algoOrder', payloadCopy, 'PUT') | ||
| } |
There was a problem hiding this comment.
The conditional check at line 603 does not perform any action when 'conditional' is present in the payload. The if block is empty (only contains commented code), so the function will continue to line 609 regardless. Either implement the conditional order update logic or remove this placeholder code.
| futuresUpdateOrder: payload => { | ||
| if (payload && 'conditional' in payload) { | ||
| // for now it is not supported | ||
| // const payloadCopy = { ...payload } | ||
| // delete payloadCopy.conditional | ||
| // return privCall('/fapi/v1/algoOrder', payloadCopy, 'PUT') | ||
| } | ||
| return privCall('/fapi/v1/order', payload, 'PUT') | ||
| }, |
There was a problem hiding this comment.
The futuresUpdateOrder implementation is inconsistent with futuresGetOrder and futuresCancelOrder patterns. Both of those methods handle conditional orders by checking the conditional flag and properly routing to the algo endpoint, and they also create a payloadCopy to remove the 'conditional' property before making the API call. Consider implementing similar logic here for consistency.
src/http-client.js
Outdated
|
|
||
| // Order endpoints | ||
| order: payload => order(privCall, payload, '/api/v3/order'), | ||
| updateOrder: payload => privCall('/api/v3/order/cancelReplace', payload, 'POST'), |
There was a problem hiding this comment.
Consider adding parameter validation or using a helper function similar to the 'order' helper used for the order endpoint. The order endpoint validates required parameters like 'symbol' and 'side' and handles automatic newClientOrderId generation. The updateOrder endpoint likely has similar requirements that should be validated.
1 participant
