Skip to content

Remove unused MemImageSet #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graeme-winter wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unused MemImageSet #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
001f42e
Remove mem image set junk dna
graeme-winter Aug 17, 2025
e969295
News
graeme-winter Aug 17, 2025
326236b
Rename newsfragments/XXX.misc to newsfragments/846.misc
DiamondLightSource-build-server Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/846.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed unused MemImageSet legacy
6 changes: 0 additions & 6 deletions src/dxtbx/model/experiment_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,6 @@ def _imageset_from_imageset_data(self, imageset_data, models):
scan=scan,
format_kwargs=format_kwargs,
)
elif imageset_data["__id__"] == "MemImageSet":
imageset = self._make_mem_imageset(imageset_data)
else:
raise RuntimeError("Unknown imageset type")

Expand Down Expand Up @@ -519,10 +517,6 @@ def decode(self):

return el

def _make_mem_imageset(self, imageset):
"""Can't make a mem imageset from dict."""
return None

def _make_stills(self, imageset, format_kwargs=None):
"""Make a still imageset."""
filenames = [
Expand Down
Loading