Skip to content

Mandate VDS for NXmx format #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graeme-winter wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mandate VDS for NXmx format #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ae6bb7
Mandate VDS for NXmx format
graeme-winter Feb 11, 2025
a5ee10b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 11, 2025
ed0c8f1
News
graeme-winter Aug 4, 2025
b926b85
Rename newsfragments/XXX.bugfix to newsfragments/785.bugfix
DiamondLightSource-build-server Aug 4, 2025
97227da
Merge branch 'main' into nxmx-no-vds
graeme-winter Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/785.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``NXmx``: require existence of /entry/data/data virtual data set to support NXmx data, fall back to FormatNexus if missing (for e.g. DECTRIS file writer data)
17 changes: 10 additions & 7 deletions src/dxtbx/format/FormatNXmx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,16 @@ class FormatNXmx(FormatNexus):
@staticmethod
def understand(image_file):
with h5py.File(image_file) as handle:
return bool(
[
entry
for entry in nxmx.find_class(handle, "NXentry")
if "definition" in entry
and nxmx.h5str(entry["definition"][()]) == "NXmx"
]
return (
bool(
[
entry
for entry in nxmx.find_class(handle, "NXentry")
if "definition" in entry
and nxmx.h5str(entry["definition"][()]) == "NXmx"
]
)
and "/entry/data/data" in handle
)

def __init__(self, image_file, **kwargs):
Expand Down
Loading