Draft
Conversation
First step towards running LogLite as a native process on ARM64 macOS, which is only natively supported in open-source Qt as of version 6.2. Required changes were mostly renamed and obsolete flags. However, there was a bigger change to replace the deprecated QRegExp usage with QRegularExpression. In particular, the file path detection needs to be sufficiently tested now.
This got lost in the initial qmake to cmake transition.
Unfortunately this comes at the cost of the taskbar icon functionality. The relevant module was removed in Qt 6. However, there is a new module pending which is meant to provide this functionality in a cross-platform way. Also, this removes the Qt 4 compatibility instructions that came in with the auto-generated CMakeLists.txt. There's room for more improvements on that front.
This broke during the qmake to cmake transition.
Another regression caused by the transition from qmake to cmake.
The TeamCity job started failing recently, and it's not entirely obvious why. Adding these arguments to the `execute_process` call should provide more insight.
Author
|
Opened by accident, this isn't ready to be merged yet. |
See code comment for details.
Either the STDOUT / STDERR pipes didn't work, or there simply is no output that's more meaningful than what we currently see on the failing mac-builders. This change should tell us at least that part.
In hindsight there is no good reason to keep the icon files in a naming convention that does not fit what iconutil expects. Sure, we save a few kilobytes of disk space, but at the expense of adding a potential breaking point in the build process. This also removes some utilities that are obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.