Add firefox keycodes for '=' and '-'.#422
Open
aroonavm wants to merge 2 commits intoccampbell:masterfrom
Open
Conversation
…renced in pull request ccampbell#215 (ccampbell#215)
Author
|
I would like to add that the keycode 173 is being used by Opera, IE, Chrome & Safari for the Mute On/Off button. (Source: http://www.javascripter.net/faq/keycodes.htm) |
Author
|
I have added a check which will only add the keycode for '-' if it is on the Firefox browser. Only Ctrl+- didn't work properly in FF which this PR should take care of. |
|
can this PR be merged? I need this feature |
JackyTung
approved these changes
Sep 19, 2019
yingray
approved these changes
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve issues referenced in pull request #215 (#215).
The above pull request can't be merged as of now. This will be useful to resolve bugs downstream.