don't block modifier key combos such as ctrl+k in inputs#387
Open
srkunze wants to merge 2 commits intoccampbell:masterfrom
Open
don't block modifier key combos such as ctrl+k in inputs#387srkunze wants to merge 2 commits intoccampbell:masterfrom
srkunze wants to merge 2 commits intoccampbell:masterfrom
Conversation
I recently found that blocking "regular combos" such as ctrl+k or alt+w in input elements confuse users badly. Since those combos don't hurt in input fields, the default should let them through.
…ect all, undo/redo, copy/cut/paste)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently found that blocking "regular combos" such as ctrl+k or alt+w in input elements confuse users badly.
Since those combos don't hurt in input fields, the default should let them through.