Skip to content

Enhancements in record plugin#301

Open
benweet wants to merge 1 commit intoccampbell:masterfrom
benweet:master
Open

Enhancements in record plugin#301
benweet wants to merge 1 commit intoccampbell:masterfrom
benweet:master

Conversation

@benweet
Copy link
Copy Markdown

@benweet benweet commented Sep 28, 2015

Here is the list of enhancements:

  • Added stopRecord function
  • Added option to disable sequence recording and to avoid the setTimeout (option is called recordSequence and is true by default, which is the original behavior)
  • Call e.preventDefault() in _handleKey to allow capturing browser shortcuts (cmd+s for example)
  • Allow to call back the record function in the callback, sounds more like a bug fix ;)

@yattias
Copy link
Copy Markdown

yattias commented Nov 14, 2015

+1

Copy link
Copy Markdown

@oumad oumad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It throws me an error (i is undefined) in the line 95. I had to add 'var i' at the line 79 for it to work.
Thank you for adding this function ! Am surprised it wasn't in the original library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants