Skip to content

Fix publish workflow #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbusillo merged 1 commit into from
Apr 26, 2026
Merged

Fix publish workflow #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ jobs:

- name: Publish to TestPyPI
if: inputs.repository == 'testpypi'
uses: pypa/gh-action-pypi-publish@v1.9.0
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/

- name: Publish to PyPI
if: inputs.repository == 'pypi'
uses: pypa/gh-action-pypi-publish@v1.9.0
uses: pypa/gh-action-pypi-publish@release/v1
3 changes: 2 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ This repository is maintained as a careful, community-oriented Python client for
- Prefer TestPyPI before first publishing under a new distribution name, but allow skipping it when CI, build metadata checks, and release-tag guards are sufficient.
- Run the manual `Publish` workflow from a `v*` release tag only.
- Keep the `testpypi` environment unblocked by manual review.
- Keep the `pypi` environment protected by maintainer approval.
- Do not require GitHub environment review for `pypi`; treat release PR merge,
tag creation, and manual workflow dispatch as the publish approval path.
- Trusted publishers must match project `printnode_community`, owner `cbusillo`, repository `printnode_community`, workflow `publish.yml`, and environment `testpypi` or `pypi`.
- Update `CHANGELOG.md` for user-visible changes.
- Keep release notes clear about whether this is an official PrintNode release or a community-maintained fork.
Expand Down
4 changes: 3 additions & 1 deletion RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ deactivate
Configure two GitHub environments before publishing:

- `testpypi`: no required reviewer, so TestPyPI dry runs do not pause.
- `pypi`: require maintainer approval before production publishing.
- `pypi`: no GitHub environment reviewer. Production approval happens by
merging the release PR, creating the release tag, and manually dispatching
the publish workflow from that tag.

Configure each environment as a trusted publisher in the corresponding PyPI
project before running the workflow. TestPyPI and PyPI are separate services;
Expand Down