Use Playwright-managed Chromium for devtools#31
Merged
Conversation
312300e to
4f328e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime-devtoolswith pinned Playwright-managed Chromium.CHROME_BINto/usr/local/bin/chromium-playwrightand update the devtools smoke test fallback path.Refs #23
Why
The xtradeb PPA endpoint has been timing out (
ppa.launchpadcontent.net:443), leavingmainred even for docs-only changes. Playwright provides multi-arch Chromium downloads with CDN fallbacks and avoids Ubuntu Snap-in-Docker issues.Local Validation
git diff --checkshellcheck scripts/smoke-devtools.shactionlint .github/workflows/*.ymljq empty .github/github-repo-workflow.jsondocker build -t odoo-docker:verify-devtools-playwright --target runtime-devtools .scripts/smoke-devtools.sh odoo-docker:verify-devtools-playwrightdocker build --platform linux/amd64 -t odoo-docker:verify-devtools-playwright-amd64 --target runtime-devtools .scripts/smoke-devtools.sh odoo-docker:verify-devtools-playwright-amd64docker run --rm --platform linux/amd64 --entrypoint /bin/bash odoo-docker:verify-devtools-playwright-amd64 -lc 'test -x "${CHROME_BIN}" && "${CHROME_BIN}" --version && readlink -f "${CHROME_BIN}"'\n\n## Notes\n- Local arm64 image inspected at about 1.0 GB.\n- Playwright downloads Chromium plus its ffmpeg helper; only Chromium is exposed throughCHROME_BIN.\n- The Chromium executable directory differs by architecture (chrome-linuxon arm64,chrome-linux64on amd64), so the Dockerfile discovers either path.