Open
Conversation
jakirkham
reviewed
May 22, 2017
|
|
||
| if(NOT MSVC) | ||
| set(RANDOMLIB_CMAKE_ARGS ${RANDOMLIB_CMAKE_ARGS} "-DCMAKE_C_FLAGS=-fpic" "-DCMAKE_CXX_FLAGS=-fpic") | ||
| endif() |
There was a problem hiding this comment.
Might be better to just change this to set CMAKE_POSITION_INDEPENDENT_CODE instead.
Owner
|
Thanks for the PR. Could you change the code to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While packaging iiboost 0.2 for conda, I ran into some issues while building on Windows with MSVC. Some of these issues have been solved already in master, for the remaining ones I had to apply the changes in this PR. It is mostly about avoiding GCC-specific flags and minor header/macros fixes.