Fix duplicate/delete node transforms and selection updates#51
Open
cbassuarez wants to merge 1 commit intomainfrom
Open
Fix duplicate/delete node transforms and selection updates#51cbassuarez wants to merge 1 commit intomainfrom
cbassuarez wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
deleteNode/duplicateNode, so UI requests couldn't reliably update the document or selection.Description
handleDuplicate/handleDeleteinto the command context and hookingDuplicate/Deletemenu commands and shortcuts to emit transform requests.runTransformand exposedhandleTransform(forTransformRequest) andhandleEditorTransform(for internalEditorTransform) to avoid request-shape mismatches.applyDeleteNodeTransformandapplyDuplicateNodeTransform, plus helpersfindNodeWithParent,cloneNodeWithNewIds, andapplyReplaceBodyNodesTransform, to update the source, index, and returnedselectedIdappropriately.{ op: ..., args: { id } }) for duplicate/delete and to update selection behavior: after delete select next sibling/prev/parent, after duplicate select the new copy.Testing
pnpm vitest packages/viewer/tests/edit-api.spec.ts; all tests passed (9 tests, 1 file), including the new duplicate/delete tests.selectedIdafter operations.Codex Task