Fix release/publish workflows and enforce pnpm workspace dependency resolution#36
Open
cbassuarez wants to merge 1 commit intomainfrom
Open
Fix release/publish workflows and enforce pnpm workspace dependency resolution#36cbassuarez wants to merge 1 commit intomainfrom
cbassuarez wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@flux-lang/*packages from the npm registry by forcing pnpm workspace resolution.ts-node/esmruntime usage in CI/publish flows which caused loader/cycle errors and blocked publishing.Description
.npmrcwithlink-workspace-packages=trueandprefer-workspace-packages=trueto force workspace resolution.@flux-lang/*version ranges in workspacepackages/*/package.jsonfiles withworkspace:^so pnpm resolves them locally.scripts/release/syncVersions.tsto preserve internal workspace ranges by always writingworkspace:^for internal deps instead of expanding to semver.scripts/release/package.jsonwith{ "type": "commonjs" }and updatescripts/release/tsconfig.jsonto compile toCommonJSwithmoduleResolution: NodeandoutDir: dist.node --loader ts-node/esm; this includes.github/workflows/publish.yml,.github/workflows/publish-canary.yml, and.github/workflows/ci.ymlchanges.pnpm install --frozen-lockfile,pnpm run build, andpnpm testso CI never runsnpm ciagainst workspace packages.Testing
pnpm install --frozen-lockfile,pnpm run build,pnpm test, and compile release scripts so upstream CI should validate the end-to-end behavior when the workflows run.Codex Task