refactor(CSS): project wide refactoring and cleanup#146
Draft
unseen-ninja wants to merge 10 commits intomainfrom
Draft
refactor(CSS): project wide refactoring and cleanup#146unseen-ninja wants to merge 10 commits intomainfrom
unseen-ninja wants to merge 10 commits intomainfrom
Conversation
removing the global CSS in favour of a component
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sgoudham
reviewed
Dec 22, 2024
| interface Props { | ||
| children: Snippet; | ||
| style?: 'mauve' | 'peach' | 'blue' | 'green' | 'transparent'; | ||
| small?: boolean; |
Contributor
There was a problem hiding this comment.
Instead of taking in small, it'll be better to take in an explicit width and height. We could default those to some number if we want.
Member
Author
There was a problem hiding this comment.
small applies to the button size in general, not just the icon size. I don't think we want to use fixed dimensions for buttons?
Contributor
There was a problem hiding this comment.
In that case, we should have an enum called ButtonSize or equivalent that can either be small or default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to reduce the CSS overhead by removing unused CSS left over from the design stage as well as improving maintanablity by simplifying rule-sets and application.